fix: added support to send post messages to parent iframe #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArushKapoorJuspay
requested review from
seekshiva,
PritishBudhiraja and
swamu
as code owners
|
Review changes with SemanticDiff. |
ArushKapoorJuspay
force-pushed
the
fix/netcetra-post-message
branch
from
670c805 to
0fbc749
Compare
PritishBudhiraja
previously approved these changes
Sep 2, 2024
PritishBudhiraja
added
the
Ready for Review
PritishBudhiraja
force-pushed
the
fix/netcetra-post-message
branch
from
0fbc749 to
e1939b2
Compare
ArushKapoorJuspay
force-pushed
the
fix/netcetra-post-message
branch
from
e1939b2 to
a5176ae
Compare
PritishBudhiraja
approved these changes
Sep 3, 2024
PritishBudhiraja
force-pushed
the
fix/netcetra-post-message
branch
from
a5176ae to
7cb7a40
Compare
github-actions
bot
added
Closed
akash-c-k
pushed a commit
that referenced
this pull request
Sep 3, 2024
## [0.84.11](v0.84.10...v0.84.11) (2024-09-03) ### Bug Fixes * added support to send post messages to parent iframe ([#594](#594)) ([638ccfc](638ccfc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Post message events being sent on the top level were not working in scenarios where the SDK along with HyperLoader and event listeners is mounted inside an iframe.
Added support to listen to such events in the parent iframe and send these post messages on level above instead of directly sending it to the top parent.
How did you test it?
Screen.Recording.2024-09-03.at.5.03.18.AM.mov
Checklist
npm run re:build