chore: rename handlePostMessage to messageParentWindow #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seekshiva
requested review from
PritishBudhiraja,
ArushKapoorJuspay and
swamu
as code owners
|
Review changes with SemanticDiff. Analyzed 1 of 38 files. File Information
|
github-actions
bot
added
the
S-conventions-not-followed
seekshiva
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
PritishBudhiraja
added
the
Ready for Review
github-actions
bot
added
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
handlePostMessagedoesn't actually "handle" a message that was posted by someone. Instead the method actually just posts a message to the parent window. So renaming it tomessageParentWindowmakes more sense.How did you test it?
Checklist
npm run re:build