-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: log event name change #550
base: main
Are you sure you want to change the base?
Conversation
fd760d2
to
5ed201c
Compare
5ed201c
to
be98292
Compare
@@ -39,7 +39,7 @@ type eventName = | |||
| APP_REINITIATED | |||
| LOG_INITIATED | |||
| LOADER_CALLED | |||
| ORCA_ELEMENTS_CALLED | |||
| WEB_SDK_IFRAME_MOUNTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain the use case of this event? Can it be something like HYPER_ELEMENTS_CALLED
or ELEMENTS_CALLED
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wanted to make it more readable to merchant in control center's audit trail. The names like HYPER_ELEMENTS_CALLED or ELEMENTS_CALLED makes more sense to Hyperswitch devs, but we wanted to make it more generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename this to PAYMENT_ELEMENTS_INITIATED
. Since we should not have WEB as a prefix for any log event. Also since this is not the only iframe which gets mounted, it will be confusing moving forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of mobile counter part of this event name is APP_RENDERED so we can use WEB as prefix for this one. Agree, PAYMENT_ELEMENTS_INITIATED is more a generic and umbrella term as it's not only about an iframe. But to a merchant iframe mounted is a more tangible event instead of something like elements initiated. The merchant should be able to derive some sense out of an event name. Let's decide a self explanatory event name for this before moving forward. cc @seekshiva @akash-c-k @PritishBudhiraja
Type of Change
Description
Renamed ORCA_ELEMENTS_CALLED to WEB_SDK_IFRAME_MOUNTED
How did you test it?
Checklist
npm run re:build