refactor: logs refactor #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanskar2001
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
Sanskar2001
force-pushed
the
logs-refactor
branch
from
f590197 to
143f4b4
Compare
| firstEvent: bool, | ||
| paymentMethod: string, | ||
| paymentMethod?: string, | ||
| metadata: JSON.t, | ||
| ephemeralKey: string, |
| firstEvent: bool, | ||
| paymentMethod: string, | ||
| paymentMethod?: string, | ||
| metadata: JSON.t, |
There was a problem hiding this comment.
is this even sent in the payload?
| paymentId: clientSecret.contents->getPaymentId, | ||
| merchantId: merchantId.contents, | ||
| browserName: arrayOfNameAndVersion->Array.get(0)->Option.getOr("Others"), | ||
| browserVersion: arrayOfNameAndVersion->Array.get(1)->Option.getOr("0"), | ||
| platform: Window.Navigator.platform, | ||
| userAgent: Window.Navigator.userAgent, | ||
| appId: "", | ||
| appId: Window.Location.hostname, |
There was a problem hiding this comment.
this will log the hostname of the iframe
This is not the expected behaviour
Consume hostname of parent from Elements over a postmessage
vsrivatsa-edinburgh
requested changes
Aug 9, 2024
PritishBudhiraja
added
Enhancement / Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Made Some keys optional instead of passing of passing empty string
How did you test it?
Checklist
npm run re:build