-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sdk pay now button enable prop added #543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakksham7
added
the
Ready for Review
PR with label Ready for Review should only be reviewed.
label
Aug 5, 2024
sakksham7
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
August 5, 2024 11:18
github-actions
bot
added
the
S-conventions-not-followed
Some Github conventions not followed
label
Aug 5, 2024
sakksham7
changed the title
Handle button disable
feat: sdk pay now button enable prop added
Aug 5, 2024
github-actions
bot
removed
the
S-conventions-not-followed
Some Github conventions not followed
label
Aug 5, 2024
seekshiva
requested changes
Aug 6, 2024
PritishBudhiraja
previously approved these changes
Aug 6, 2024
PritishBudhiraja
previously approved these changes
Aug 7, 2024
PritishBudhiraja
previously approved these changes
Aug 7, 2024
seekshiva
approved these changes
Aug 7, 2024
github-actions
bot
added
the
Closed
Label will be automatically added when the PR will get merged to main
label
Aug 7, 2024
akash-c-k
pushed a commit
that referenced
this pull request
Aug 7, 2024
# [0.81.0](v0.80.7...v0.81.0) (2024-08-07) ### Features * sdk pay now button enable prop added ([#543](#543)) ([bf7a505](bf7a505))
PritishBudhiraja
removed
the
Ready for Review
PR with label Ready for Review should only be reviewed.
label
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added a prop for SDK Pay now button for enabling and disabling it, until all the validations are checked and correct.
By passing boolean value to that prop the SDK Pay now button can be enabled or disabled.
Before:
After(passing button enable as true):
How did you test it?
passed value of prop in CheckoutForm.js and then rendered the SDK.
Checklist
npm run re:build