Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdk pay now button enable prop added #543

Merged
merged 14 commits into from
Aug 7, 2024
Merged

Conversation

sakksham7
Copy link
Contributor

@sakksham7 sakksham7 commented Aug 5, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added a prop for SDK Pay now button for enabling and disabling it, until all the validations are checked and correct.
By passing boolean value to that prop the SDK Pay now button can be enabled or disabled.

Before:
Screenshot 2024-08-05 at 6 39 24 PM

After(passing button enable as true):
Screenshot 2024-08-05 at 6 39 45 PM

How did you test it?

passed value of prop in CheckoutForm.js and then rendered the SDK.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 added the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 5, 2024
@sakksham7 sakksham7 self-assigned this Aug 5, 2024
@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Aug 5, 2024
@sakksham7 sakksham7 changed the title Handle button disable feat: sdk pay now button enable prop added Aug 5, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Some Github conventions not followed label Aug 5, 2024
src/orca-loader/Hyper.res Outdated Show resolved Hide resolved
@seekshiva seekshiva merged commit bf7a505 into main Aug 7, 2024
3 checks passed
@seekshiva seekshiva deleted the handle-button-disable branch August 7, 2024 11:40
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Aug 7, 2024
akash-c-k pushed a commit that referenced this pull request Aug 7, 2024
# [0.81.0](v0.80.7...v0.81.0) (2024-08-07)

### Features

* sdk pay now button enable prop added ([#543](#543)) ([bf7a505](bf7a505))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants