refactor: moving declarations in window into a sub-module #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakksham7
requested review from
seekshiva,
PritishBudhiraja,
ArushKapoorJuspay and
vsrivatsa-edinburgh
as code owners
sakksham7
added
Enhancement / Refactoring
PritishBudhiraja
approved these changes
Jul 17, 2024
github-actions
bot
added
the
Closed
PritishBudhiraja
removed
Enhancement / Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
moved declarations in window under a sub-module to make rescript code as close to corresponding JS code as possible.
How did you test it?
tested by starting the demo app and checking if everything is working fine
Checklist
npm run re:build