Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date of birth validations #480

Merged
merged 9 commits into from
Jul 9, 2024
Merged

fix: date of birth validations #480

merged 9 commits into from
Jul 9, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja commented Jul 8, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added null values in Date of Birth so Placeholder text can be shown.

Added validations for handling error that it should be > 18 years

How did you test it?

Via opening Mifinity

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Jul 8, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Jul 8, 2024
@PritishBudhiraja PritishBudhiraja linked an issue Jul 8, 2024 that may be closed by this pull request
@PritishBudhiraja PritishBudhiraja changed the title fix: date of birth null value fix: date of birth validations Jul 8, 2024
@PritishBudhiraja PritishBudhiraja merged commit 8d9c620 into main Jul 9, 2024
3 checks passed
@PritishBudhiraja PritishBudhiraja deleted the dob-null-object branch July 9, 2024 11:02
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Jul 9, 2024
akash-c-k pushed a commit that referenced this pull request Jul 9, 2024
## [0.73.2](v0.73.1...v0.73.2) (2024-07-09)

### Bug Fixes

* date of birth validations ([#480](#480)) ([8d9c620](8d9c620))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date of Birth - Placeholder text not coming & Age validations
2 participants