Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: headless applepay and googlepay #454

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

ArushKapoorJuspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added the following changes -

  1. ApplePay one time payment for confirmWithLastUsedPaymentMethod (Headless)
  2. GooglePay one time payment for confirmWithLastUsedPaymentMethod (Headless)
  3. If GooglePay or ApplePay are not supported by browser or sessions call, remove from customers list
  4. GooglePay svg not coming for saved GooglePay methods
  5. Added sorting priority logic of payment methods for customer payment methods as well

How did you test it?

  1. ApplePay and GooglePay should work one time and saved
  2. ApplePay or GooglePay should not be visible in the saved payment methods list if browser or session not supported
  3. GooglePay Saved Payment method icon should be visible
  4. Sorting logic of payment methods should work for customer payment methods as well

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@ArushKapoorJuspay ArushKapoorJuspay force-pushed the feat/headless-apple-pay branch from 0d3fe14 to ea6a6d9 Compare June 24, 2024 00:22
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good please make sure you have tested this with normal happy flow too
cuz i see default required fields array which shouldnt affect other methods

@prafulkoppalkar prafulkoppalkar merged commit 238d806 into main Jun 24, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the feat/headless-apple-pay branch June 24, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants