Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort saved customer methods #427

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Sort the saved PM.

How did you test it?

Via sorting the UI list

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Jun 6, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Jun 6, 2024
@PritishBudhiraja
Copy link
Collaborator Author

One open question-

  1. Is the default one always comes on top?
  2. If I'm sorting should I sort and update the list via default on top?

@prafulkoppalkar @ArushKapoorJuspay

@prafulkoppalkar
Copy link
Contributor

One open question-

  1. Is the default one always comes on top?
  2. If I'm sorting should I sort and update the list via default on top?

@prafulkoppalkar @ArushKapoorJuspay

Should sort the list in last used order

@PritishBudhiraja
Copy link
Collaborator Author

One open question-

  1. Is the default one always comes on top?
  2. If I'm sorting should I sort and update the list via default on top?

@prafulkoppalkar @ArushKapoorJuspay

Should sort the list in last used order

Then it will be possible that default can come in middle.

@prafulkoppalkar prafulkoppalkar merged commit d923d7f into main Jun 13, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the saved-methods-sort branch June 13, 2024 11:00
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Jun 13, 2024
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants