Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdk button redirect issue #398

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fix for redirect as it was been passed in wrong place

How did you test it?

Via passing redirect = always and checking the redirection

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label May 23, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this May 23, 2024
@prafulkoppalkar prafulkoppalkar merged commit dd78d56 into main May 23, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the sdk-button-redirect-fix branch May 23, 2024 10:57
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 23, 2024
akash-c-k pushed a commit that referenced this pull request May 23, 2024
## [0.54.2](v0.54.1...v0.54.2) (2024-05-23)

### Bug Fixes

* sdk button redirect issue ([#398](#398)) ([dd78d56](dd78d56))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
## [0.54.2](juspay/hyperswitch-web@v0.54.1...v0.54.2) (2024-05-23)

### Bug Fixes

* sdk button redirect issue ([#398](juspay/hyperswitch-web#398)) ([dd78d56](juspay/hyperswitch-web@dd78d56))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants