Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change payment token type from tuple to object #388

Merged
merged 1 commit into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Components/SavedCardItem.res
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,13 @@ let make = (
boxShadow: "none",
opacity: {isCardExpired ? "0.7" : "1"},
}
onClick={_ => setPaymentToken(_ => (paymentItem.paymentToken, paymentItem.customerId))}>
onClick={_ => {
open RecoilAtomTypes
setPaymentToken(_ => {
paymentToken: paymentItem.paymentToken,
customerId: paymentItem.customerId,
})
}}>
<div className="w-full">
<div>
<div className="flex flex-row justify-between items-center">
Expand Down
16 changes: 8 additions & 8 deletions src/Components/SavedMethods.res
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@react.component
let make = (
~paymentToken,
~paymentToken: RecoilAtomTypes.paymentToken,
~setPaymentToken,
~savedMethods: array<PaymentType.customerMethods>,
~loadSavedCards: PaymentType.savedCardsLoadState,
Expand All @@ -24,10 +24,11 @@ let make = (
let isGuestCustomer = useIsGuestCustomer()

let intent = PaymentHelpers.usePaymentIntent(Some(loggerState), Card)
let (token, _) = paymentToken
let savedCardlength = savedMethods->Array.length
let paymentMethodListValue = Recoil.useRecoilValueFromAtom(PaymentUtils.paymentMethodListValue)

let {paymentToken: paymentTokenVal, customerId} = paymentToken

let getWalletBrandIcon = (obj: PaymentType.customerMethods) => {
switch obj.paymentMethodType {
| Some("apple_pay") => <Icon size=brandIconSize name="apple_pay_saved" />
Expand Down Expand Up @@ -57,7 +58,7 @@ let make = (
""->CardThemeType.getPaymentMode,
)
}
let isActive = token == obj.paymentToken
let isActive = paymentTokenVal == obj.paymentToken
<SavedCardItem
key={i->Belt.Int.toString}
setPaymentToken
Expand All @@ -76,15 +77,14 @@ let make = (

let (isCVCValid, _, cvcNumber, _, _, _, _, _, _, setCvcError) = cvcProps
let complete = switch isCVCValid {
| Some(val) => token !== "" && val
| Some(val) => paymentTokenVal !== "" && val
| _ => false
}
let empty = cvcNumber == ""
let (token, customerId) = paymentToken
let customerMethod =
savedMethods
->Array.filter(savedMethod => {
savedMethod.paymentToken === token
savedMethod.paymentToken === paymentTokenVal
})
->Array.get(0)
->Option.getOr(PaymentType.defaultCustomerMethods)
Expand All @@ -108,7 +108,7 @@ let make = (
let savedPaymentMethodBody = switch customerMethod.paymentMethod {
| "card" =>
PaymentBody.savedCardBody(
~paymentToken=token,
~paymentToken=paymentTokenVal,
~customerId,
~cvcNumber,
~requiresCvv=customerMethod.requiresCvv,
Expand All @@ -121,7 +121,7 @@ let make = (
| Some(paymentMethodType) => paymentMethodType->JSON.Encode.string
}
PaymentBody.savedPaymentMethodBody(
~paymentToken=token,
~paymentToken=paymentTokenVal,
~customerId,
~paymentMethod=customerMethod.paymentMethod,
~paymentMethodType,
Expand Down
3 changes: 1 addition & 2 deletions src/Payment.res
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ let make = (~paymentMode, ~integrateError, ~logger) => {
let showFields = Recoil.useRecoilValueFromAtom(showCardFieldsAtom)
let selectedOption = Recoil.useRecoilValueFromAtom(selectedOptionAtom)
let paymentToken = Recoil.useRecoilValueFromAtom(paymentTokenAtom)
let (token, _) = paymentToken

let {iframeId} = keys

Expand Down Expand Up @@ -214,7 +213,7 @@ let make = (~paymentMode, ~integrateError, ~logger) => {
setCardError(_ => "")
setExpiryError(_ => "")
None
}, (token, showFields))
}, (paymentToken.paymentToken, showFields))

let submitValue = (_ev, confirmParam) => {
let validFormat = switch paymentMode->getPaymentMode {
Expand Down
6 changes: 5 additions & 1 deletion src/PaymentElement.res
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ let make = (~cardProps, ~expiryProps, ~cvcProps, ~paymentType: CardThemeType.mod
}

switch tokenObj {
| Some(obj) => setPaymentToken(_ => (obj.paymentToken, obj.customerId))
| Some(obj) =>
setPaymentToken(_ => {
paymentToken: obj.paymentToken,
customerId: obj.customerId,
})
| None => ()
}
None
Expand Down
7 changes: 7 additions & 0 deletions src/Types/RecoilAtomTypes.res
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,10 @@ type field = {
errorString: string,
countryCode?: string,
}

type load = Loading | Loaded(JSON.t) | LoadError

type paymentToken = {
paymentToken: string,
customerId: string,
}
12 changes: 8 additions & 4 deletions src/Utilities/RecoilAtoms.res
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
type load = Loading | Loaded(JSON.t) | LoadError
open RecoilAtomTypes

let keys = Recoil.atom("keys", CommonHooks.defaultkeys)
let configAtom = Recoil.atom("defaultRecoilConfig", CardTheme.defaultRecoilConfig)
Expand All @@ -12,14 +12,18 @@ let sessionId = Recoil.atom("sessionId", "")
let isConfirmBlocked = Recoil.atom("isConfirmBlocked", false)
let switchToCustomPod = Recoil.atom("switchToCustomPod", false)
let selectedOptionAtom = Recoil.atom("selectedOption", "")
let paymentTokenAtom = Recoil.atom("paymentToken", ("", ""))
let paymentTokenAtom = Recoil.atom(
"paymentToken",
{
paymentToken: "",
customerId: "",
},
)
let showCardFieldsAtom = Recoil.atom("showCardFields", false)
let phoneJson = Recoil.atom("phoneJson", Loading)
let cardBrand = Recoil.atom("cardBrand", "")
let payNowButtonDisable = Recoil.atom("payNowButtonDisable", true)

open RecoilAtomTypes

let defaultFieldValues = {
value: "",
isValid: None,
Expand Down
Loading