Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove expired saved cards #345

Merged
merged 13 commits into from
May 3, 2024
Merged

fix: remove expired saved cards #345

merged 13 commits into from
May 3, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja commented May 2, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

We were able to see saved cards which were expired. Filtered from fronted to don't see the expired cards.

Screenshot 2024-05-03 at 11 52 02 AM

How did you test it?

Check for expired cards in locker and these shouldn't come in Saved PM Screen.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label May 2, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this May 2, 2024
@PritishBudhiraja PritishBudhiraja mentioned this pull request May 2, 2024
Closed
@PritishBudhiraja PritishBudhiraja linked an issue May 2, 2024 that may be closed by this pull request
Remove expired saved cards #346
Closed
vsrivatsa25
vsrivatsa25 suggested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@vsrivatsa25 vsrivatsa25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card is valid through the card.expiryMonth. Need to compare with next expiryMonth + 1 or expiryYear + 1 if expiryMonth == 12

Pritish Budhiraja added 2 commits May 2, 2024 15:19
vsrivatsa25
vsrivatsa25 reviewed May 2, 2024
View reviewed changes
src/PaymentElement.res Outdated Show resolved Hide resolved
@vsrivatsa25
Update src/PaymentElement.res
8e437b0 
Co-authored-by: Vrishab Srivatsa <[email protected]>
@akash-c-k akash-c-k merged commit 97b66c7 into main May 3, 2024
3 checks passed
@akash-c-k akash-c-k deleted the saved-expired-cards-filter branch May 3, 2024 11:02
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 3, 2024
akash-c-k pushed a commit that referenced this pull request May 3, 2024
@semantic-release-bot
chore(release): 0.48.2 [skip ci]
8cdd30d 
## [0.48.2](v0.48.1...v0.48.2) (2024-05-03)

### Bug Fixes

* remove expired saved cards ([#345](#345)) ([97b66c7](97b66c7))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
@rising-dragon401
chore(release): 0.48.2 [skip ci]
d7c56b1 
## [0.48.2](juspay/hyperswitch-web@v0.48.1...v0.48.2) (2024-05-03)

### Bug Fixes

* remove expired saved cards ([#345](juspay/hyperswitch-web#345)) ([97b66c7](juspay/hyperswitch-web@97b66c7))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArushKapoorJuspay ArushKapoorJuspay ArushKapoorJuspay approved these changes

@vsrivatsa25 vsrivatsa25 Awaiting requested review from vsrivatsa25

@vsrivatsa-edinburgh vsrivatsa-edinburgh Awaiting requested review from vsrivatsa-edinburgh

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove expired saved cards
5 participants
@PritishBudhiraja @vsrivatsa25 @ArushKapoorJuspay @vsrivatsa-edinburgh @akash-c-k