refactor: paymentmethod list prop drilldown refactor #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
added
the
Ready for Review
PritishBudhiraja
requested review from
prafulkoppalkar and
25harsh
as code owners
ArushKapoorJuspay
requested changes
May 6, 2024
prafulkoppalkar
previously approved these changes
May 6, 2024
…method-list-drilldown
ArushKapoorJuspay
approved these changes
May 6, 2024
prafulkoppalkar
approved these changes
May 6, 2024
github-actions
bot
added
the
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
We were drilling down the prop from parent level to inner child levels. Moved that prop into recoil and used all over.
How did you test it?
Code refactoring. Basic sanity is done.
Checklist
npm run re:build