refactor: country props drilling removal #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
added
the
Development In Progress
added 5 commits
April 17, 2024 16:07
…h-web into refactor-country-props
ArushKapoorJuspay
approved these changes
Apr 18, 2024
PritishBudhiraja
added
Ready for Review
prafulkoppalkar
approved these changes
Apr 18, 2024
github-actions
bot
added
the
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The country props were not getting used and we were prop drilling so it's better to use in recoil if needed.
How did you test it?
Basic checks. Only code refactoring.
Checklist
npm run re:build