-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: promise unresolved type error #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date payment For end users it looked like Promise is being unresolved as the button was being stuck in the loading state.
Promise stays unresolved when the return_url is invalid or when there is a type error while handling the response from /confirm call
github-actions
bot
added
the
S-conventions-not-followed
Some Github conventions not followed
label
Apr 16, 2024
prafulkoppalkar
added
Ready for Review
PR with label Ready for Review should only be reviewed.
Do not merge
and removed
S-conventions-not-followed
Some Github conventions not followed
Do not merge
labels
Apr 16, 2024
prafulkoppalkar
changed the title
Fix/promise unresolved type error
fix: promise unresolved type error
Apr 17, 2024
ArushKapoorJuspay
previously approved these changes
Apr 17, 2024
prafulkoppalkar
force-pushed
the
fix/promise_unresolved_type_error
branch
from
April 17, 2024 09:29
b781f08
to
77a9ee8
Compare
ArushKapoorJuspay
approved these changes
Apr 17, 2024
vsrivatsa-edinburgh
approved these changes
Apr 17, 2024
github-actions
bot
added
the
Closed
Label will be automatically added when the PR will get merged to main
label
Apr 17, 2024
akash-c-k
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [0.42.4](v0.42.3...v0.42.4) (2024-04-17) ### Bug Fixes * promise unresolved type error ([#298](#298)) ([03da575](03da575))
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
## [0.42.4](juspay/hyperswitch-web@v0.42.3...v0.42.4) (2024-04-17) ### Bug Fixes * promise unresolved type error ([#298](juspay/hyperswitch-web#298)) ([03da575](juspay/hyperswitch-web@03da575))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Closed
Label will be automatically added when the PR will get merged to main
Ready for Review
PR with label Ready for Review should only be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promise being unresolved
Type of Change
Checklist
npm run re:build