Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: promise unresolved type error #298

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

prafulkoppalkar
Copy link
Contributor

Description

Promise being unresolved

  • if any of the confirm params are invalid
  • if there is a runtime error while handling the response from /confirm call

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

…date payment

For end users it looked like Promise is being unresolved as the button was being stuck in the
loading state.
Promise stays unresolved when the return_url is invalid or when there is a type error while
handling the response from /confirm call
@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Apr 16, 2024
@prafulkoppalkar prafulkoppalkar added Ready for Review PR with label Ready for Review should only be reviewed. Do not merge and removed S-conventions-not-followed Some Github conventions not followed Do not merge labels Apr 16, 2024
@prafulkoppalkar prafulkoppalkar changed the title Fix/promise unresolved type error fix: promise unresolved type error Apr 17, 2024
@prafulkoppalkar prafulkoppalkar force-pushed the fix/promise_unresolved_type_error branch from b781f08 to 77a9ee8 Compare April 17, 2024 09:29
@prafulkoppalkar prafulkoppalkar merged commit 03da575 into main Apr 17, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the fix/promise_unresolved_type_error branch April 17, 2024 09:37
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Apr 17, 2024
akash-c-k pushed a commit that referenced this pull request Apr 17, 2024
## [0.42.4](v0.42.3...v0.42.4) (2024-04-17)

### Bug Fixes

* promise unresolved type error ([#298](#298)) ([03da575](03da575))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
## [0.42.4](juspay/hyperswitch-web@v0.42.3...v0.42.4) (2024-04-17)

### Bug Fixes

* promise unresolved type error ([#298](juspay/hyperswitch-web#298)) ([03da575](juspay/hyperswitch-web@03da575))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants