-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: phone country dropdown added #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
requested review from
prafulkoppalkar and
ArushKapoorJuspay
as code owners
April 3, 2024 11:47
prafulkoppalkar
previously approved these changes
Apr 4, 2024
PritishBudhiraja
added
the
Added Comments - waiting for author
Add this label when comments added in the PR and waiting for the author to get those resolved.
label
Apr 5, 2024
PritishBudhiraja
added
Ready for Review
PR with label Ready for Review should only be reviewed.
and removed
Added Comments - waiting for author
Add this label when comments added in the PR and waiting for the author to get those resolved.
labels
Apr 5, 2024
…umber-validations
…umber-validations
…umber-validations
prafulkoppalkar
previously approved these changes
May 8, 2024
ArushKapoorJuspay
previously approved these changes
May 10, 2024
…umber-validations
…tch-web into phone-number-validations
PritishBudhiraja
dismissed stale reviews from ArushKapoorJuspay and prafulkoppalkar
via
May 10, 2024 09:16
288c04f
ArushKapoorJuspay
approved these changes
May 10, 2024
prafulkoppalkar
approved these changes
May 10, 2024
github-actions
bot
added
the
Closed
Label will be automatically added when the PR will get merged to main
label
May 10, 2024
akash-c-k
pushed a commit
that referenced
this pull request
May 10, 2024
# [0.51.0](v0.50.14...v0.51.0) (2024-05-10) ### Features * phone country dropdown added ([#270](#270)) ([f6a945c](f6a945c))
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
# [0.51.0](juspay/hyperswitch-web@v0.50.14...v0.51.0) (2024-05-10) ### Features * phone country dropdown added ([#270](juspay/hyperswitch-web#270)) ([f6a945c](juspay/hyperswitch-web@f6a945c))
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from HS-127-Jenkins-updated to main * commit 'dd5430531a2572baf67520b0a69281ed96485687': feat: HS-127: updated jenkins file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Closed
Label will be automatically added when the PR will get merged to main
Ready for Review
PR with label Ready for Review should only be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
need to add a drop down for all the phone country code values
How did you test it?
Rendered the phone number field and we can check the dropdown is visible with all country - phone number code values
Checklist
npm run re:build