Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removed ApplePay from Tabs and collecting Dynamic Fields in ApplePay Modal #264

Closed
wants to merge 1 commit into from
Closed

feat: removed ApplePay from Tabs and collecting Dynamic Fields in ApplePay Modal #264

wants to merge 1 commit into from

Conversation

ArushKapoorJuspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Moved ApplePay outside of tabs when Dynamic Fields was enabled. Collecting required fields inside Apple Modal and sending them to backend in the confirm call. (Fields will be collecting from Apple based on payment_request_data received in Session Token)

How did you test it?

  1. Test transaction when ApplePay without required fields
  2. Test transaction when ApplePay with required fields

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@ArushKapoorJuspay ArushKapoorJuspay changed the title feat: removed ApplePay from Tabs and collecting Dynamic Fields in ApplePay Modal [DO NOT MERGE] feat: removed ApplePay from Tabs and collecting Dynamic Fields in ApplePay Modal Mar 28, 2024
@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Mar 28, 2024
@PritishBudhiraja PritishBudhiraja changed the title [DO NOT MERGE] feat: removed ApplePay from Tabs and collecting Dynamic Fields in ApplePay Modal feat: removed ApplePay from Tabs and collecting Dynamic Fields in ApplePay Modal Apr 5, 2024
@PritishBudhiraja PritishBudhiraja added the Development In Progress Use this label if you have raised the PR but development is still under progress label Apr 5, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Some Github conventions not followed label Apr 5, 2024
@ArushKapoorJuspay ArushKapoorJuspay added Ready for Review PR with label Ready for Review should only be reviewed. and removed Development In Progress Use this label if you have raised the PR but development is still under progress labels Apr 29, 2024
ArushKapoorJuspay added a commit that referenced this pull request Sep 23, 2024
@ArushKapoorJuspay
Pull request #264: HOTFIX - Divide by zero error fix
9d805ad 
Merge in EXC/orca-elements from fix/ui-improvements to master

* commit '95f46ec371e88a326e3acb19c7673ab88090c70d':
  HOTFIX - Divide by zero error fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prafulkoppalkar prafulkoppalkar prafulkoppalkar approved these changes

Assignees

@ArushKapoorJuspay ArushKapoorJuspay

Labels
Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArushKapoorJuspay @prafulkoppalkar @PritishBudhiraja