Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: applePay Dynamic Fields Error Handling and Dynamic Fields PostalCode Error #250

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ArushKapoorJuspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. ApplePay Dynamic Fields Error handling failing. The merchant button getting stuck in Processing...
  2. Dynamic Fields areRequiredFieldsValid failing because of postal code validation in scenario (found by not passing country in /create-payment-intent call)

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@@ -333,7 +333,7 @@ let make = (
None
}, (isApplePayReady, isInvokeSDKFlow, paymentExperience, isWallet))

let submitCallback = (ev: Window.event) => {
let submitCallback = React.useCallback2((ev: Window.event) => {
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change - React.useCallback2 to React.useCallback

akash-c-k
akash-c-k previously approved these changes Mar 22, 2024
@akash-c-k akash-c-k merged commit d85aa2a into main Mar 22, 2024
3 checks passed
@akash-c-k akash-c-k deleted the fix/apple-pay-dynamic-fields branch March 22, 2024 11:11
akash-c-k pushed a commit that referenced this pull request Mar 22, 2024
## [0.34.1](v0.34.0...v0.34.1) (2024-03-22)

### Bug Fixes

* applePay Dynamic Fields Error Handling and Dynamic Fields PostalCode Error ([#250](#250)) ([d85aa2a](d85aa2a))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
## [0.34.1](juspay/hyperswitch-web@v0.34.0...v0.34.1) (2024-03-22)

### Bug Fixes

* applePay Dynamic Fields Error Handling and Dynamic Fields PostalCode Error ([#250](juspay/hyperswitch-web#250)) ([d85aa2a](juspay/hyperswitch-web@d85aa2a))
ArushKapoorJuspay pushed a commit that referenced this pull request Sep 23, 2024
Merge in EXC/orca-elements from pumpACHDebitChanges to master

* commit '1c23d8c417b1c193560574a9981e308156cd1bb9':
  comments addressed
  payment body changes
  clearSpace removed
  ACH Debit changes for Pump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants