Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3DS without redirection #249

Merged
merged 6 commits into from
Mar 22, 2024
Merged

feat: 3DS without redirection #249

merged 6 commits into from
Mar 22, 2024

Conversation

prafulkoppalkar
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

3DS Method call
3DS Auth Call
handled without redirection using popups
challenge & frictionless flow also handled

How did you test it?

testing app with 3ds enabled cards
multiple times with challenge and frictionless flow

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Mar 21, 2024
@prafulkoppalkar prafulkoppalkar changed the title Feat/three ds Feat - 3DS without redirection Mar 21, 2024
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert all Js module and Belt module functions to Core module to maintain consistency throughout the codebase

@PritishBudhiraja PritishBudhiraja changed the title Feat - 3DS without redirection feat: 3DS without redirection Mar 22, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Some Github conventions not followed label Mar 22, 2024
src/ThreeDSAuth.res Outdated Show resolved Hide resolved
src/ThreeDSAuth.res Outdated Show resolved Hide resolved
src/ThreeDSMethod.res Outdated Show resolved Hide resolved
src/ThreeDSMethod.res Outdated Show resolved Hide resolved
src/App.res Show resolved Hide resolved
src/ThreeDSAuth.res Outdated Show resolved Hide resolved
src/ThreeDSAuth.res Outdated Show resolved Hide resolved
src/ThreeDSAuth.res Outdated Show resolved Hide resolved
src/ThreeDSMethod.res Outdated Show resolved Hide resolved
src/ThreeDSMethod.res Outdated Show resolved Hide resolved
@ArushKapoorJuspay
Copy link
Contributor

Why is the package-lock.json file pushed?

Copy link
Contributor Author

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved most of the comments

@akash-c-k akash-c-k merged commit 70911e5 into main Mar 22, 2024
3 checks passed
@akash-c-k akash-c-k deleted the feat/threeDs branch March 22, 2024 10:59
akash-c-k pushed a commit that referenced this pull request Mar 22, 2024
# [0.34.0](v0.33.12...v0.34.0) (2024-03-22)

### Features

* 3DS without redirection ([#249](#249)) ([70911e5](70911e5))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
# [0.34.0](juspay/hyperswitch-web@v0.33.12...v0.34.0) (2024-03-22)

### Features

* 3DS without redirection ([#249](juspay/hyperswitch-web#249)) ([70911e5](juspay/hyperswitch-web@70911e5))
ArushKapoorJuspay added a commit that referenced this pull request Sep 23, 2024
Merge in EXC/orca-elements from fix/ui-improvements to master

* commit 'd0773b926cee32b78958711b93377e66ae3f873c':
  Ui Improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants