fix: disable sdk button changes #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
requested review from
prafulkoppalkar,
akash-c-k and
ArushKapoorJuspay
as code owners
github-actions
bot
added
the
S-conventions-not-followed
PritishBudhiraja
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
added 6 commits
March 21, 2024 11:47
prafulkoppalkar
previously approved these changes
Apr 4, 2024
added 2 commits
April 4, 2024 18:02
prafulkoppalkar
approved these changes
Apr 4, 2024
vsrivatsa-edinburgh
approved these changes
Apr 4, 2024
akash-c-k
pushed a commit
that referenced
this pull request
Apr 4, 2024
## [0.38.1](v0.38.0...v0.38.1) (2024-04-04) ### Bug Fixes * disable sdk button changes ([#244](#244)) ([164ffdb](164ffdb))
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
## [0.38.1](juspay/hyperswitch-web@v0.38.0...v0.38.1) (2024-04-04) ### Bug Fixes * disable sdk button changes ([#244](juspay/hyperswitch-web#244)) ([164ffdb](juspay/hyperswitch-web@164ffdb))
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from bugfix/removing-values-from-logs to master * commit 'bb0ae458a913786219ef1040dd6d1a9832149860': Added STRIPE_ELEMENTS_CALLED in list of priority events Minor change Remove unused variants/code chunks Added internal metadata field, Log exceptions as json directly :( , Remove payloads from log (value)
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from bugfix/removing-values-from-logs to master * commit 'bb0ae458a913786219ef1040dd6d1a9832149860': Added STRIPE_ELEMENTS_CALLED in list of priority events Minor change Remove unused variants/code chunks Added internal metadata field, Log exceptions as json directly :( , Remove payloads from log (value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The Pay Now button for SDK was not getting enabled for all the Payment methods that's new way we have added in this PR to fix this issue
How did you test it?
Just went through all Payment Methods and filled all the required fields. If all required fields are filled, then the SDK Pay Now Button Should be enabled.
Checklist
npm run re:build