Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added Wallets to Saved Payment Methods #213

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

ArushKapoorJuspay
Copy link
Contributor

fix #197

UI Changes
Screenshot 2024-03-08 at 3 30 34 AM
Screenshot 2024-03-08 at 3 30 44 AM
Screenshot 2024-03-08 at 3 30 55 AM

Confirm Call Changes
Screenshot 2024-03-08 at 4 23 05 AM
Screenshot 2024-03-08 at 4 23 23 AM

akash-c-k
akash-c-k previously approved these changes Mar 8, 2024
prafulkoppalkar
prafulkoppalkar previously approved these changes Mar 8, 2024
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

src/Payments/CardPayment.res Outdated Show resolved Hide resolved
Base automatically changed from feat/savedCardsFlowChange to main March 8, 2024 13:58
@akash-c-k akash-c-k dismissed stale reviews from prafulkoppalkar and themself March 8, 2024 13:58

The base branch was changed.

@ArushKapoorJuspay ArushKapoorJuspay force-pushed the fix/wallets-saved-payment branch 5 times, most recently from 4a56351 to d6f0f6c Compare March 11, 2024 18:08
…rds outside card form

SavedCards component is coupled with card form and being rendered inside the card form. Moved it
outside the card form since there is scope have savedMethods
@ArushKapoorJuspay ArushKapoorJuspay force-pushed the fix/wallets-saved-payment branch from d6f0f6c to e9e0701 Compare March 11, 2024 19:53
@ArushKapoorJuspay ArushKapoorJuspay force-pushed the fix/wallets-saved-payment branch from e9e0701 to 155e2f1 Compare March 11, 2024 20:06
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging this

@prafulkoppalkar prafulkoppalkar merged commit dc6a194 into main Mar 11, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the fix/wallets-saved-payment branch March 11, 2024 20:11
akash-c-k pushed a commit that referenced this pull request Mar 11, 2024
## [0.29.1](v0.29.0...v0.29.1) (2024-03-11)

### Bug Fixes

* added Wallets to Saved Payment Methods ([#213](#213)) ([dc6a194](dc6a194))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
## [0.29.1](juspay/hyperswitch-web@v0.29.0...v0.29.1) (2024-03-11)

### Bug Fixes

* added Wallets to Saved Payment Methods ([#213](juspay/hyperswitch-web#213)) ([dc6a194](juspay/hyperswitch-web@dc6a194))
ArushKapoorJuspay pushed a commit that referenced this pull request Sep 23, 2024
Merge in EXC/orca-elements from praful/permanentFix to master

* commit '7fecd79ad4d950ee07d1a29466e92e2e5465d73c':
  changed the pub key check logic
  Added a check for prod key removed warning for disableSavedCard prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants