fix: HS:132: reverting changes for cardholder name (#74)

Co-authored-by: arun.mishra <[email protected]>
juspay · Dec 20, 2023 · c11b32b · c11b32b
1 parent 58bba25
commit c11b32b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/src/Components/DynamicFields.res b/src/Components/DynamicFields.res
@@ -313,7 +313,7 @@ let make = (
           setFields(setEmail, email, requiredField, false)
           if emailValue === "" {
             let newEmail: RecoilAtomTypes.field = {
-              value: value,
+              value,
               isValid: None,
               errorString: "",
             }
@@ -437,7 +437,7 @@ let make = (
           if !isAllStoredCardsHaveName {
             acc->Js.Dict.set(
               "payment_method_data.card_token.card_holder_name",
-              value === "" ? Js.Json.null : value->Js.Json.string,
+              value->Js.Json.string,
             )
           }
         } else {
@@ -676,7 +676,8 @@ let make = (
                     options=bankNames
                   />
                 | SpecialField(element) => element
-                | InfoElement => <>
+                | InfoElement =>
+                  <>
                     <Surcharge list paymentMethod paymentMethodType />
                     {if fieldsArr->Js.Array2.length > 1 {
                       bottomElement

diff --git a/src/Utilities/PaymentBody.res b/src/Utilities/PaymentBody.res
@@ -11,10 +11,7 @@ let cardPaymentBody = (~cardNumber, ~month, ~year, ~cardHolderName, ~cvcNumber,
           ("card_number", cardNumber->CardUtils.clearSpaces->Js.Json.string),
           ("card_exp_month", month->Js.Json.string),
           ("card_exp_year", year->Js.Json.string),
-          (
-            "card_holder_name",
-            cardHolderName === "" ? Js.Json.null : cardHolderName->Js.Json.string,
-          ),
+          ("card_holder_name", cardHolderName->Js.Json.string),
           ("card_cvc", cvcNumber->Js.Json.string),
           ("card_issuer", ""->Js.Json.string),
         ]
@@ -43,10 +40,7 @@ let bancontactBody = (~cardNumber, ~month, ~year, ~cardHolderName) => [
               ("card_number", cardNumber->CardUtils.clearSpaces->Js.Json.string),
               ("card_exp_month", month->Js.Json.string),
               ("card_exp_year", year->Js.Json.string),
-              (
-                "card_holder_name",
-                cardHolderName === "" ? Js.Json.null : cardHolderName->Js.Json.string,
-              ),
+              ("card_holder_name", cardHolderName->Js.Json.string),
             ]
             ->Js.Dict.fromArray
             ->Js.Json.object_,