Skip to content

Commit

Permalink
fix: isolate thirdparty confirm requests to legacy endpoints, rest to…
Browse files Browse the repository at this point in the history
… cdn endpoints
  • Loading branch information
Vrishab Srivatsa committed Apr 30, 2024
1 parent 1bf85c8 commit 5ff47f2
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
10 changes: 6 additions & 4 deletions src/Payments/ApplePay.res
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ let make = (

let isGuestCustomer = UtilityHooks.useIsGuestCustomer()

let processPayment = bodyArr => {
let processPayment = (bodyArr, isThirdPartyFlow) => {
let requestBody = PaymentUtils.appendedCustomerAcceptance(
~isGuestCustomer,
~paymentType=list.payment_type,
Expand All @@ -69,6 +69,7 @@ let make = (
publishableKey,
},
~handleUserError=true,
~isThirdPartyFlow,
(),
)
} else {
Expand All @@ -86,6 +87,7 @@ let make = (
publishableKey,
},
~handleUserError=true,
~isThirdPartyFlow,
(),
)
}
Expand Down Expand Up @@ -264,14 +266,14 @@ let make = (
if isDelayedSessionToken {
setShowApplePayLoader(_ => true)
let bodyDict = PaymentBody.applePayThirdPartySdkBody(~connectors)
processPayment(bodyDict)
processPayment(bodyDict, true)
} else {
let message = [("applePayButtonClicked", true->JSON.Encode.bool)]
Utils.handlePostMessage(message)
}
} else {
let bodyDict = PaymentBody.applePayRedirectBody(~connectors)
processPayment(bodyDict)
processPayment(bodyDict, false)
}
} else {
setApplePayClicked(_ => false)
Expand All @@ -295,7 +297,7 @@ let make = (
let token =
dict->Dict.get("applePayProcessPayment")->Option.getOr(Dict.make()->JSON.Encode.object)
let bodyDict = PaymentBody.applePayBody(~token, ~connectors)
processPayment(bodyDict)
processPayment(bodyDict, false)
} else if dict->Dict.get("showApplePayButton")->Option.isSome {
setApplePayClicked(_ => false)
if !isWallet {
Expand Down
9 changes: 5 additions & 4 deletions src/Payments/GPay.res
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,15 @@ let make = (
->Option.getOr(false)
}, [thirdPartySessionObj])

let processPayment = (body: array<(string, JSON.t)>) => {
let processPayment = (body: array<(string, JSON.t)>, isThirdPartyFlow) => {
intent(
~bodyArr=body,
~confirmParam={
return_url: options.wallets.walletReturnUrl,
publishableKey,
},
~handleUserError=true,
~isThirdPartyFlow,
(),
)
}
Expand Down Expand Up @@ -103,7 +104,7 @@ let make = (
->mergeTwoFlattenedJsonDicts(requiredFieldsBody)
->getArrayOfTupleFromDict
}
processPayment(body)
processPayment(body, false)
}
if dict->Dict.get("gpayError")->Option.isSome {
Utils.handlePostMessage([("fullscreen", false->JSON.Encode.bool)])
Expand Down Expand Up @@ -157,7 +158,7 @@ let make = (
("iframeId", iframeId->JSON.Encode.string),
])
let bodyDict = PaymentBody.gPayThirdPartySdkBody(~connectors)
processPayment(bodyDict)
processPayment(bodyDict, true)
} else {
handlePostMessage([
("fullscreen", true->JSON.Encode.bool),
Expand All @@ -168,7 +169,7 @@ let make = (
}
} else {
let bodyDict = PaymentBody.gpayRedirectBody(~connectors)
processPayment(bodyDict)
processPayment(bodyDict, false)
}
}
resolve()
Expand Down
3 changes: 2 additions & 1 deletion src/Utilities/PaymentHelpers.res
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,7 @@ let usePaymentIntent = (optLogger, paymentType) => {
~bodyArr: array<(string, JSON.t)>,
~confirmParam: ConfirmType.confirmParams,
~iframeId=keys.iframeId,
~isThirdPartyFlow=false,
(),
) => {
switch keys.clientSecret {
Expand All @@ -925,7 +926,7 @@ let usePaymentIntent = (optLogger, paymentType) => {
])
let endpoint = ApiEndpoint.getApiEndPoint(
~publishableKey=confirmParam.publishableKey,
~isConfirmCall=true,
~isConfirmCall=!isThirdPartyFlow,
(),
)
let uri = `${endpoint}/payments/${paymentIntentID}/confirm`
Expand Down

0 comments on commit 5ff47f2

Please sign in to comment.