Skip to content

Commit

Permalink
fix: move thirdparty applepay event listeners outside of handleSessio…
Browse files Browse the repository at this point in the history
…nTokensLoaded event listener

wrap session.canMakePayments() in try catch to catch exception, fixed payment data filled logs
  • Loading branch information
Vrishab Srivatsa committed Apr 28, 2024
1 parent 95451bd commit 261ce6f
Show file tree
Hide file tree
Showing 3 changed files with 251 additions and 212 deletions.
7 changes: 0 additions & 7 deletions src/Payments/ApplePay.res
Original file line number Diff line number Diff line change
Expand Up @@ -273,13 +273,6 @@ let make = (
let bodyDict = PaymentBody.applePayRedirectBody(~connectors)
processPayment(bodyDict)
}
let value = "Payment Data Filled: New Payment Method"
loggerState.setLogInfo(
~value,
~eventName=PAYMENT_DATA_FILLED,
~paymentMethod="APPLE_PAY",
(),
)
} else {
setApplePayClicked(_ => false)
}
Expand Down
7 changes: 0 additions & 7 deletions src/Payments/GPay.res
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,6 @@ let make = (
makeOneClickHandlerPromise(sdkHandleOneClickConfirmPayment)->then(result => {
let result = result->JSON.Decode.bool->Option.getOr(false)
if result {
let value = "Payment Data Filled: New Payment Method"
loggerState.setLogInfo(
~value,
~eventName=PAYMENT_DATA_FILLED,
~paymentMethod="GOOGLE_PAY",
(),
)
if isInvokeSDKFlow {
if isDelayedSessionToken {
handlePostMessage([
Expand Down
Loading

0 comments on commit 261ce6f

Please sign in to comment.