refactor(payments): add card_holder_name to request only if the value…

… is present
juspay · Dec 11, 2024 · 1081d14 · 1081d14
1 parent 098f7ee
commit 1081d14
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/src/Payment.res b/src/Payment.res
@@ -239,7 +239,7 @@ let make = (~paymentMode, ~integrateError, ~logger) => {
           ~cardNumber,
           ~month,
           ~year,
-          ~cardHolderName="",
+          ~cardHolderName=None,
           ~cvcNumber,
           ~cardBrand=cardNetwork,
         )
@@ -250,7 +250,7 @@ let make = (~paymentMode, ~integrateError, ~logger) => {
           ~cardNumber,
           ~month,
           ~year,
-          ~cardHolderName="",
+          ~cardHolderName=None,
           ~cvcNumber=localCvcNumber,
           ~cardBrand=cardNetwork,
         )

diff --git a/src/Payments/CardPayment.res b/src/Payments/CardPayment.res
@@ -142,7 +142,7 @@ let make = (
       ~cardNumber,
       ~month,
       ~year,
-      ~cardHolderName="",
+      ~cardHolderName=None,
       ~cvcNumber,
       ~cardBrand=cardNetwork,
       ~nickname,

diff --git a/src/Types/PaymentType.res b/src/Types/PaymentType.res
@@ -862,7 +862,7 @@ let getCardDetails = (dict, str) => {
       expiryMonth: getString(json, "expiry_month", ""),
       expiryYear: getString(json, "expiry_year", ""),
       cardToken: getString(json, "card_token", ""),
-      cardHolderName: Some(getString(json, "card_holder_name", "")),
+      cardHolderName: getOptionString(json, "card_holder_name"),
       nickname: getString(json, "nick_name", ""),
     }
   })

diff --git a/src/Utilities/PaymentBody.res b/src/Utilities/PaymentBody.res
@@ -35,7 +35,7 @@ let cardPaymentBody = (
   ~cardNumber,
   ~month,
   ~year,
-  ~cardHolderName,
+  ~cardHolderName=None,
   ~cvcNumber,
   ~cardBrand,
   ~nickname="",
@@ -44,11 +44,14 @@ let cardPaymentBody = (
     ("card_number", cardNumber->CardUtils.clearSpaces->JSON.Encode.string),
     ("card_exp_month", month->JSON.Encode.string),
     ("card_exp_year", year->JSON.Encode.string),
-    ("card_holder_name", cardHolderName->JSON.Encode.string),
     ("card_cvc", cvcNumber->JSON.Encode.string),
     ("card_issuer", ""->JSON.Encode.string),
   ]
 
+  cardHolderName
+  ->Option.map(name => cardBody->Array.push(("card_holder_name", name->JSON.Encode.string))->ignore)
+  ->ignore
+
   if nickname != "" {
     cardBody->Array.push(("nick_name", nickname->JSON.Encode.string))->ignore
   }