Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: group-drop-down-component-changes #97

Merged
merged 11 commits into from
Dec 19, 2023
Merged

feat: group-drop-down-component-changes #97

merged 11 commits into from
Dec 19, 2023

Conversation

PritishBudhiraja
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

image image

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja requested a review from a team as a code owner December 14, 2023 11:10
@PritishBudhiraja PritishBudhiraja self-assigned this Dec 15, 2023
@PritishBudhiraja PritishBudhiraja added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 15, 2023
JeevaRamu0104
JeevaRamu0104 reviewed Dec 15, 2023
View reviewed changes
src/components/InputFields.resi Show resolved Hide resolved
src/components/InputFields.resi Show resolved Hide resolved
src/components/SelectBox.res Outdated Show resolved Hide resolved
@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 15, 2023
@PritishBudhiraja PritishBudhiraja added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Dec 15, 2023
@PritishBudhiraja PritishBudhiraja added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit adcd89e Dec 19, 2023
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the group-drop-down-component branch December 26, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PritishBudhiraja @Riddhiagrawal001 @JeevaRamu0104