Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default id for connector label #84

Merged
merged 17 commits into from
Dec 12, 2023
Merged

feat: default id for connector label #84

merged 17 commits into from
Dec 12, 2023

Conversation

PritishBudhiraja
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja requested a review from a team as a code owner December 11, 2023 07:25
@PritishBudhiraja PritishBudhiraja self-assigned this Dec 11, 2023
@PritishBudhiraja PritishBudhiraja added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 11, 2023
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 11, 2023
View reviewed changes
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 11, 2023
View reviewed changes
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 11, 2023
View reviewed changes
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 12, 2023
View reviewed changes
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit cc09ab5 Dec 12, 2023
3 checks passed
@jainlokesh318 jainlokesh318 deleted the connector-profile-id-default branch December 12, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainlokesh318 jainlokesh318 jainlokesh318 approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 left review comments

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PritishBudhiraja @jainlokesh318 @JeevaRamu0104