Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 3ds code refactor and bugfixes #61

Merged
merged 17 commits into from
Dec 6, 2023
Merged

fix: 3ds code refactor and bugfixes #61

merged 17 commits into from
Dec 6, 2023

Conversation

Riddhiagrawal001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner December 5, 2023 06:22
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 5, 2023
@Riddhiagrawal001 Riddhiagrawal001 changed the title enhancement: 3ds code refactor and bugfixes core: 3ds code refactor and bugfixes Dec 5, 2023
@Riddhiagrawal001 Riddhiagrawal001 changed the title core: 3ds code refactor and bugfixes chore: 3ds code refactor and bugfixes Dec 5, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 5, 2023
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Dec 5, 2023
@Riddhiagrawal001 Riddhiagrawal001 changed the title chore: 3ds code refactor and bugfixes fix: 3ds code refactor and bugfixes Dec 5, 2023
@JeevaRamu0104 JeevaRamu0104 added the S-in-progress Status: Implementation is underway label Dec 5, 2023
Riddhi Agrawal added 2 commits December 5, 2023 15:03
fix: validations issue fix + 3ds keys updated
0f846c0
Merge branch 'HCC-929-removed-metadata-from-3-ds-bugfixes' of github.…
10fce27 
…com:juspay/hyperswitch-control-center into HCC-929-removed-metadata-from-3-ds-bugfixes
@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-in-progress Status: Implementation is underway labels Dec 5, 2023
Merge branch 'main' of github.com:juspay/hyperswitch-control-center i…
1422f4c 
…nto HCC-929-removed-metadata-from-3-ds-bugfixes
@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 5, 2023
@JeevaRamu0104 JeevaRamu0104 merged commit 9d4f503 into main Dec 6, 2023
3 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the HCC-929-removed-metadata-from-3-ds-bugfixes branch December 6, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Riddhiagrawal001 @JeevaRamu0104 @PritishBudhiraja