Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: connector label update #279

Merged
merged 8 commits into from
Feb 14, 2024
Merged

fix: connector label update #279

merged 8 commits into from
Feb 14, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Jan 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner January 22, 2024 13:03
@Riddhiagrawal001 Riddhiagrawal001 linked an issue Jan 22, 2024 that may be closed by this pull request
[BUG] Allow connector label update on Connector update flow #280
Closed
@Riddhiagrawal001 Riddhiagrawal001 changed the title fix: connector label udpate fix:connector label udpate Jan 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 changed the title fix:connector label udpate fix:connector label update Jan 22, 2024
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 changed the title fix:connector label update fix: connector label update Jan 22, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 22, 2024
PritishBudhiraja
PritishBudhiraja approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected ✨

@Riddhiagrawal001 Riddhiagrawal001 added the S-blocked Status: Blocked on something else or other implementation work label Jan 23, 2024
@PritishBudhiraja PritishBudhiraja removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 29, 2024
@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-blocked Status: Blocked on something else or other implementation work labels Feb 8, 2024
@PritishBudhiraja PritishBudhiraja added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 4442ae4 Feb 14, 2024
4 checks passed
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 14, 2024
@PritishBudhiraja PritishBudhiraja deleted the fix/connector-label-update-fix branch February 19, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Allow connector label update on Connector update flow
3 participants
@Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104