Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make basic details form to accept form input without Save button #271

Merged
merged 8 commits into from
Jan 19, 2024
Merged

fix: make basic details form to accept form input without Save button #271

merged 8 commits into from
Jan 19, 2024

Conversation

jainlokesh318
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@jainlokesh318 jainlokesh318 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 18, 2024
@jainlokesh318 jainlokesh318 self-assigned this Jan 18, 2024
@jainlokesh318 jainlokesh318 requested a review from a team as a code owner January 18, 2024 08:57
@jainlokesh318 jainlokesh318 linked an issue Jan 18, 2024 that may be closed by this pull request
[FEATURE] Simplify the routing save and configure action #208
Closed
2 tasks
@JeevaRamu0104 JeevaRamu0104 added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 19, 2024
@jainlokesh318 jainlokesh318 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jan 19, 2024
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 3784090 Jan 19, 2024
5 checks passed
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 19, 2024
@JeevaRamu0104 JeevaRamu0104 deleted the fix/routingBasicDetails branch January 19, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Assignees

@jainlokesh318 jainlokesh318

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Simplify the routing save and configure action
3 participants
@jainlokesh318 @PritishBudhiraja @JeevaRamu0104