Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: floating point value fix for test payment #270

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: floating point value fix for test payment #270

merged 1 commit into from
Jan 18, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Jan 18, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner January 18, 2024 08:22
@Riddhiagrawal001 Riddhiagrawal001 linked an issue Jan 18, 2024 that may be closed by this pull request
[BUG] Floating point values getting converted to Int in Test payment #269
Closed
@Riddhiagrawal001 Riddhiagrawal001 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 18, 2024
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 038a714 Jan 18, 2024
5 checks passed
@PritishBudhiraja PritishBudhiraja added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 23, 2024
@PritishBudhiraja PritishBudhiraja deleted the fix/floating-point-issue-test-payment branch January 23, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Floating point values getting converted to Int in Test payment
3 participants
@Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104