feat: customer table pagination #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarnaikjuspay
added
S-waiting-on-review
|
Review changes with |
gitanjli525
previously approved these changes
Jan 15, 2025
kanikabansal-juspay
approved these changes
Jan 16, 2025
gitanjli525
approved these changes
Jan 16, 2025
github-actions
bot
added
Closed
| @@ -25,7 +51,7 @@ let make = () => { | |||
| React.useEffect(() => { | |||
| getCustomersList()->ignore | |||
| None | |||
| }, []) | |||
| }, [offset]) | |||
There was a problem hiding this comment.
Rather adding has a dependencies call the have handleClick function for offset and then call the getCustomersList function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
pagination implementation for customer table,
currently api response doesn't contains total_count so the total numbers of pages has been set to 50 for nowand user can change between the pagesMotivation and Context
How did you test it?
while changing the page diff cuotomers will be listed out in the table, and the max number of pages is 50 and table can have no data but still can contain number of pages displyaed is 50
Where to test it?
Checklist
npm run re:build