Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list invitation error on logout from recon #1944

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix: list invitation error on logout from recon #1944

merged 4 commits into from
Dec 17, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

After the logout event was triggered from Recon, the dashboard was redirecting to the home page, which then called the "list invitations" API. This resulted in an error because the local storage was cleared during the logout process.

Motivation and Context

How did you test it?

  • Login to account having recon
  • when the recon iframe throws error dashboard was logging out with error 'failed to fetch list invitations'

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added the bug bug label Dec 17, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Dec 17, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner December 17, 2024 06:34
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@Riddhiagrawal001 Riddhiagrawal001 linked an issue Dec 17, 2024 that may be closed by this pull request
fix: list invitation error on logout from recon #1945
Closed
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 939457d Dec 17, 2024
5 of 6 checks passed
@prajwalnl0 prajwalnl0 deleted the list-invitation-error-from-recon-logout branch December 17, 2024 13:02
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed bug bug labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: list invitation error on logout from recon
4 participants
@Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104 @prajwalnl0