Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Auth page UI changes #101

Merged
merged 18 commits into from
Dec 26, 2023
Merged

chore: Auth page UI changes #101

merged 18 commits into from
Dec 26, 2023

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Dec 15, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Fix Stretching Animation (P1) across the whole flow
  • Add button loading state before loggin/signing up people in/ sending mail
  • Fix Juspay logo
  • Crosscheck the text size in implementation with figma desings
  • Scaling of the card upon toggling signup/sign cta (P0)

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner December 15, 2023 09:58
@sagarnaikjuspay sagarnaikjuspay self-assigned this Dec 15, 2023
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 15, 2023
@sagarnaikjuspay sagarnaikjuspay changed the title Auth page UI changes chore: Auth page UI changes Dec 15, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 15, 2023
@sagarnaikjuspay sagarnaikjuspay added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 15, 2023
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 19, 2023
View reviewed changes
src/components/form/FormRenderer.res Outdated Show resolved Hide resolved
@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 19, 2023
@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Dec 20, 2023
@JeevaRamu0104 JeevaRamu0104 merged commit 3873c1b into main Dec 26, 2023
4 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the auth-page-ui-changes branch December 26, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@sagarnaikjuspay sagarnaikjuspay

Labels
S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagarnaikjuspay @JeevaRamu0104 @PritishBudhiraja