fix: global search enter listener (#1797)

juspay · Nov 25, 2024 · ec03f6d · ec03f6d
1 parent 6af0622
commit ec03f6d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/src/screens/Analytics/GlobalSearch/GlobalSearchBar.res b/src/screens/Analytics/GlobalSearch/GlobalSearchBar.res
@@ -38,18 +38,6 @@ let make = () => {
     }
   }
 
-  React.useEffect(() => {
-    let onKeyPress = event => {
-      let keyPressed = event->ReactEvent.Keyboard.key
-
-      if keyPressed == "Enter" {
-        selectedOption->redirectOnSelect
-      }
-    }
-    Window.addEventListener("keydown", onKeyPress)
-    Some(() => Window.removeEventListener("keydown", onKeyPress))
-  }, [])
-
   let getCategoryOptions = async () => {
     setState(_ => Loading)
     try {

diff --git a/src/screens/Analytics/GlobalSearch/GlobalSearchBarHelper.res b/src/screens/Analytics/GlobalSearch/GlobalSearchBarHelper.res
@@ -398,7 +398,7 @@ module ModalSearchBox = {
         | Some(val) => setSelectedOption(_ => val)
         | _ => ()
         }
-      } else if e->keyCode == 13 {
+      } else if e->keyCode == 13 && localSearchText->isNonEmptyString {
         selectedOption->redirectOnSelect
       }