Feature/extract fitness calculator #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the classes for finding possible watch faces and generating the code for the different times.
That includes using correct indentation, white spaces around keywords and operators, etc
Since introduction of StringBuilder it should generally be used over its threadsafe and therefore less performing counterpart.
Although the traditional way has no direct issues, foreach is more readable and therefore preferred.
Is not necessary since Java 6.
Since Java 7 it is not necessary to explicitly specify the type in generics if the type can be inferred by the variable declaration.
Generally anonymous inner classes are much easier to read and write with lambdas. Additionally comparators are good candidates as well.
Classes should only expose whats necessary for others to read. Otherwise we increase accidentally coupling between classes.
Initializer should only be set to something beside default values if it has actual meaning. Otherwise the arbitrary value might convey meaning to something it actually hasn't.
Refine extraction as well. It's still far away from ideal but its already easier to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a major refactoring of the code.