Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Test on webkit #175

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/playwright-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
browser: [firefox, chromium]
browser: [firefox, chromium, webkit]

steps:
- name: React to the triggering comment
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
strategy:
fail-fast: false
matrix:
browser: [firefox, chromium]
browser: [firefox, chromium, webkit]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
10 changes: 9 additions & 1 deletion ui-tests/test/execute.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) JupyterLite Contributors

Check failure on line 1 in ui-tests/test/execute.test.ts

View workflow job for this annotation

GitHub Actions / Visual Regression (webkit)

[webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution

1) [webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution ────────────────── Test timeout of 180000ms exceeded.

Check failure on line 1 in ui-tests/test/execute.test.ts

View workflow job for this annotation

GitHub Actions / Visual Regression (webkit)

[webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution

1) [webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution ────────────────── Pending operations: - locator.waitFor at node_modules/@jupyterlab/galata/src/helpers/notebook.ts:385:23
// Distributed under the terms of the Modified BSD License.

import { test } from '@jupyterlab/galata';
Expand All @@ -14,10 +14,18 @@
await page.goto('lab/index.html');
});

test('Basic code execution', async ({ page }) => {
test('Basic code execution', async ({ page, browserName }) => {
if (browserName === 'webkit') {
// try waiting longer for webkit
test.setTimeout(60000 * 3);
}
await page.notebook.createNew();

// TODO: remove
// See https://github.com/jupyterlab/jupyterlab/issues/15252 for more information
await page.notebook.setCell(0, 'code', '2 + 2');
await page.notebook.setCell(0, 'code', '2 + 2');
await page.notebook.run();

Check failure on line 28 in ui-tests/test/execute.test.ts

View workflow job for this annotation

GitHub Actions / Visual Regression (webkit)

[webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution

1) [webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution ────────────────── Error: locator.waitFor: Page closed =========================== logs =========================== waiting for locator('#jp-main-statusbar').locator('text=Idle') to be visible ============================================================ 26 | await page.notebook.setCell(0, 'code', '2 + 2'); 27 | await page.notebook.setCell(0, 'code', '2 + 2'); > 28 | await page.notebook.run(); | ^ 29 | const output = await page.notebook.getCellTextOutput(0); 30 | 31 | expect(output).toBeTruthy(); at NotebookHelper.waitForRun (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:385:23) at NotebookHelper.run (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:276:16) at /home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/test/execute.test.ts:28:5
const output = await page.notebook.getCellTextOutput(0);

expect(output).toBeTruthy();
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading