Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version_info to the ipykernel mock #53

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Add version_info to the ipykernel mock #53

merged 3 commits into from
Aug 3, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 3, 2023 •
edited
Loading

To help support the new ipywidgets 8.1.0.

Fixes jupyter-widgets/ipywidgets#3819

image

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio added the bug Something isn't working label Aug 3, 2023
@jtpio jtpio marked this pull request as ready for review August 3, 2023 06:27
@jtpio jtpio requested a review from martinRenou August 3, 2023 06:27
@martinRenou martinRenou mentioned this pull request Aug 3, 2023
Merged
martinRenou
martinRenou approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

I can come up with a PR preparing the land for using only the comm module.

@martinRenou martinRenou merged commit 0df94b5 into jupyterlite:main Aug 3, 2023
10 checks passed
@jtpio
Copy link
Member Author

jtpio commented Aug 3, 2023

I can come up with a PR preparing the land for using only the comm module.

Sure thanks!

I'll start a 0.0.10 release in the meantime to get this one out.

@jtpio jtpio deleted the version-info branch August 3, 2023 06:50
@martinRenou martinRenou mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipykernel error with ipywidgets 8.1 and jupyterlite
2 participants
@jtpio @martinRenou