Use filepath relative to repo root #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #22
The docs mention that the
urlpathparameter is relative to the repository root (see https://litegitpuller.readthedocs.io/en/latest/index.html#parameters), which is currently not the case.This PR fixes the code to interpret the
urlpathparameter relative to the repository root, which is a breaking change. This behaviour is useful when the repo is not uploaded to a statically known path, e.g. by (in the future) uploading it to the currently opened working directory.While we theoretically could detect paths starting with
tree/to get back the original behaviour, this would clash with folders namedtreeinside the repository. Opening a path outside the repo is still possible by giving an absolute path, e.g./README.md(since absolute paths come out of a join unchanged and JupyterLab strips the leading slash).