Preserve file extension for unique filenames #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file is uploaded and has a name clash, a unique filename must be chosen. The current method appends the increment after the pathname, which interferes with the file extension, e.g.
README.md
becomesREADME.md_0
. (Since the contents API uses the extension to determine how to interpret the file, this causes plain text files to be displayed as base64 encoded). The new variant puts the disambiguator in front to preserve the extension.