Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if nbgitpuller extension is installed #20

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Test if nbgitpuller extension is installed #20

merged 6 commits into from
Jul 24, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jul 23, 2024 •
edited
Loading

Fixes #5

This PR add a test on nbgitpuller extension, by making a request to one of its endpoint.

If nbgitpuller extension is enabled, litegitpuller is not activated, to avoid fetching two times the same repo.

cc @jtpio, who suggests this workaround

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a Binder on branch brichet/litegitpuller/conflict_nbgitpuller

@brichet brichet added the bug Something isn't working label Jul 23, 2024
@brichet brichet marked this pull request as ready for review July 23, 2024 12:08
@brichet brichet mentioned this pull request Jul 23, 2024
Closed
@brichet brichet changed the title Test nbgitpuller API to make sure it is not installed Test if nbgitpuller extension is installed Jul 23, 2024
jtpio
jtpio reviewed Jul 23, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
jtpio
jtpio approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit f83164e into jupyterlite:main Jul 24, 2024
8 checks passed
@jtpio
Copy link
Member

jtpio commented Jul 24, 2024

Will release in a 0.2.0 since this may introduce a change of behavior.

@brichet brichet deleted the conflict_nbgitpuller branch July 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if the current application is JupyterLite
2 participants
@brichet @jtpio