Making the LLM providers more generics #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brichet
changed the title
jtpio
reviewed
Oct 31, 2024
src/chat-handler.ts
Outdated
| if (this._llmClient === null) { | ||
| const botMsg: IChatMessage = { | ||
| id: UUID.uuid4(), | ||
| body: '**Chat client not configured**', |
There was a problem hiding this comment.
Maybe we can open a new issue to track translating this string (and maybe others) with the ITranslator?
jtpio
reviewed
Oct 31, 2024
src/chat-handler.ts
Outdated
| this._llmClient = options.llmClient; | ||
| } | ||
|
|
||
| get llmClient(): BaseChatModel | null { |
There was a problem hiding this comment.
Wondering if "provider" could also be a good name as an alternative to llmClient? Or something else similar to what Jupyter AI uses?
jtpio
reviewed
Oct 31, 2024
src/index.ts
Outdated
| id: 'jupyterlab-codestral:llm-provider', | ||
| autoStart: true, | ||
| requires: [ICompletionProviderManager, ISettingRegistry], | ||
| provides: ILlmProvider, |
There was a problem hiding this comment.
ILlmProvider may read a bit awkward with the change of casing between the two "L". Maybe ILLMProvider or IAIProvider could also work? (or something else)
|
It would be interesting to follow-up by adding support for another provider, for example OpenAI. Edit: opened #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of changing LLM provider, even if only MistralAI is available at the moment.
A unique inline completion provider is registered to the manager.
This inline completion provider relies on a completer specific to the LLM used, to correctly call the LLM API.
Adding a new LLM would be to:
TODO, probably in a follow up PR: dynamically update the available settings when the selected provider has changed.