Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tags in history sidebar #1272

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Oct 5, 2023

In the history panel, show the tags (if they exist) next to the commits they are pointing to.

For this, the implementation of an ITag interface was required, such that for each tag we keep not only its name, but also the id of the commit it points to.

export interface ITag {
    name: string;
    baseCommitId?: string;
}

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Binder 👈 Launch a Binder on branch DenisaCG/jupyterlab-git/tagsHistorySidebar

@DenisaCG DenisaCG marked this pull request as draft October 5, 2023 08:59
@DenisaCG DenisaCG marked this pull request as ready for review October 6, 2023 09:06
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DenisaCG

@fcollonval fcollonval merged commit 6fd13f4 into jupyterlab:main Oct 10, 2023
8 checks passed
@DenisaCG DenisaCG deleted the tagsHistorySidebar branch October 10, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants