Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable automatic inline completions #981

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

krassowski
Copy link
Member

Closes #968

Allows to disable completion on typing for jupyter-ai provider. Adds one setting field with two options:

Default New option
image Screenshot from 2024-09-07 11-45-59

The label can be easily adjusted as the underlying value has a separate enum. In future more options could be added, e.g. "automatic in code, manual in markdown".

@krassowski krassowski added the enhancement New feature or request label Sep 7, 2024
@krassowski
Copy link
Member Author

krassowski commented Sep 7, 2024

Oh, pre-commit does not include typescript linter (I opened #982).

Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 👍

@dlqqq dlqqq enabled auto-merge (squash) September 9, 2024 20:57
@dlqqq dlqqq merged commit 43e6acc into jupyterlab:main Sep 9, 2024
8 checks passed
@krassowski krassowski deleted the setting-invoke-manual-only branch September 11, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a setting allowing to only invoke inline completion on manual trigger
2 participants