Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify labels for k8s-objects like DaemonSets and Deployments #2976

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nlcti
Copy link

@nlcti nlcti commented Dec 13, 2022

Hi,
I was requested by a client to label all k8s objects of the Jupyterhub helm chart with additional, team specific informations.

Therefore I added a helper function called jupyterhub.determinedLabels to the _helpers.tpl, which extracts given labels from the values.yaml and appends them to the commonLabels.

As far as I see it, this solution overlaps with the pull request #2948 .
As it reaches out not only for the Deployment-objects, but everything which gets labeled via commonLabels, I suppose it is more generic.

@welcome
Copy link

welcome bot commented Dec 13, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant