-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opengraph tags #2717
Add opengraph tags #2717
Conversation
@manics wieee nice!! I observe it to not yet function though based on the PR preview. I did this on discourse.jupyter.org: It sais it fails to find |
agree w/ @consideRatio - we need to add a bit of configuration to get the base url right etc, and then the link metadata / logo should show up properly |
I've added some tags for https://cards-dev.twitter.com/validator refuses to load the rendered RTD pages because bots are blocked by |
The other option mentioned in pydata/pydata-sphinx-theme#664 (comment)
If we can include ogp_image = "_static/logo.png"
ogp_use_first_image = True in |
@manics I think you are right! See the difference between the preview robots.txt https://zero-to-jupyterhub.org.readthedocs.build/robots.txt vs the production robots.txt https://z2jh.jupyter.org/robots.txt. robots.txt is blocked in the preview setting, but not for RTD production pages not meant for preview. It makes sense, they should stop scrapers etc from finding preview pages. I think things may work if we merge this :) |
@manics if we define a jupyterhub theme we could also consider defining some extensions that are automatically installed in all of our repositories (e.g. |
Jupyter readthedocs sites are often referenced on the Jupyter Discourse. The lack of Open Graph tags means link previews aren't useful, e.g. in the compose mode
This uses sphinxext-opengraph as suggested by @choldgraf in pydata/pydata-sphinx-theme#664