Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shellcheck action to lint bash #82

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add shellcheck action to lint bash #82

wants to merge 1 commit into from

Conversation

yuvipanda
Copy link
Collaborator

No description provided.

@choldgraf
Copy link
Member

Quick thought - could we set this up as a pre-commit hook and then use pre-commit.ci to automatically make any necessary changes, rather than just doing a lint? https://github.com/jumanjihouse/pre-commit-hooks

@yuvipanda
Copy link
Collaborator Author

Am happy for someone else to do that, as that is probably more time than I have now unfortunately

@choldgraf
Copy link
Member

If that's too much extra work, then I'm +1 on just fixing the linting error this PR is surfacing, and merging it in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @choldgraf