Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All] Authorize allowed_users, admin_users, _or_ other allowed/admin groups #594

Merged
merged 57 commits into from
Jun 23, 2023
Merged

[All] Authorize allowed_users, admin_users, _or_ other allowed/admin groups #594

merged 57 commits into from
Jun 23, 2023

Commits on Jun 13, 2023

  1. Fix generic admin_groups bug

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6bde66e View commit details
    Browse the repository at this point in the history

  2. Update openshift also

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    3309dd5 View commit details
    Browse the repository at this point in the history

  3. Update google tests

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b680635 View commit details
    Browse the repository at this point in the history

  4. Fix google auth groups logic

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d5f9bdf View commit details
    Browse the repository at this point in the history

  5. Move static method in base class

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    0c717c1 View commit details
    Browse the repository at this point in the history

  6. User should be authorized also if only in admin groups

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a807e18 View commit details
    Browse the repository at this point in the history

  7. Update missing funcs

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6290b7b View commit details
    Browse the repository at this point in the history

  8. Add test for the bug in openshift

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e11edea View commit details
    Browse the repository at this point in the history

  9. Update func signature as no longer needed

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ba14061 View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6e52be2 View commit details
    Browse the repository at this point in the history

  11. Authorize based on group membership if allowed_users is not set

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ca2e466 View commit details
    Browse the repository at this point in the history

  12. Update authorization funcs

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4fda822 View commit details
    Browse the repository at this point in the history

  13. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1e5992a View commit details
    Browse the repository at this point in the history

  14. Fix typo

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e43a9c2 View commit details
    Browse the repository at this point in the history

  15. Check if user was allowed through before checking groups

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    554fd76 View commit details
    Browse the repository at this point in the history

  16. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    43f60ae View commit details
    Browse the repository at this point in the history

  17. Fix typo

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    15d62f8 View commit details
    Browse the repository at this point in the history

  18. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    3c25adb View commit details
    Browse the repository at this point in the history

  19. Rework attempt before considering overriding Authenticator.check_allowed

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c5b3762 View commit details
    Browse the repository at this point in the history

  20. Draft work with check_allowed

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    41a0db2 View commit details
    Browse the repository at this point in the history

  21. Additional progress on cilogon and mediawiki

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a3cf070 View commit details
    Browse the repository at this point in the history

  22. Update tests

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    071c411 View commit details
    Browse the repository at this point in the history

  23. Fixes from running tests

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    bfaaa11 View commit details
    Browse the repository at this point in the history

  24. Add and update fixme comments while developing

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b8227ac View commit details
    Browse the repository at this point in the history

  25. Update where admin status is set and considered

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    91dfb03 View commit details
    Browse the repository at this point in the history

  26. Update cilogon to reflect latest discussions about taking priority ov… 

    …er when set
    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6d16946 View commit details
    Browse the repository at this point in the history

  27. Change user_is_authorised for check_allowed in github

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    26065b8 View commit details
    Browse the repository at this point in the history

  28. Change user_is_authorised for check_allowed in gitlab

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    effc9fd View commit details
    Browse the repository at this point in the history

  29. Reorder

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d5a3dd9 View commit details
    Browse the repository at this point in the history

  30. Change user_is_authorised for check_allowed in globus

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    9afefa2 View commit details
    Browse the repository at this point in the history

  31. Add note about updating auth_model in GitHub

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    35338a6 View commit details
    Browse the repository at this point in the history

  32. Small fixes

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    fcfe088 View commit details
    Browse the repository at this point in the history

  33. Change user_is_authorised for check_allowed for google

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    980fb5e View commit details
    Browse the repository at this point in the history

  34. Raise a 403 instead of 500 when logging in using an unallowed domain 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    93b14a9 View commit details
    Browse the repository at this point in the history

  35. Use username var directly since it's available 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c9bbbca View commit details
    Browse the repository at this point in the history

  36. Fix comment 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    98692b1 View commit details
    Browse the repository at this point in the history

  37. Fix typo 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ec139e1 View commit details
    Browse the repository at this point in the history

  38. Rm extra quote 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    97cc182 View commit details
    Browse the repository at this point in the history

  39. Fix group related comment 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a982e1b View commit details
    Browse the repository at this point in the history

  40. Move comment to a place where it makes more sense

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    11b35cb View commit details
    Browse the repository at this point in the history

  41. Rm todo comment 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b7b87d3 View commit details
    Browse the repository at this point in the history

  42. Remove fixme and track it in a todo item

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1dcb1ee View commit details
    Browse the repository at this point in the history

  43. Set admin status exclusively in for all authenticators

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    fb12f5f View commit details
    Browse the repository at this point in the history

  44. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    0d21f60 View commit details
    Browse the repository at this point in the history

  45. Update comment to match implementation

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    25dc2ae View commit details
    Browse the repository at this point in the history

  46. Set version from membership check func

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b44d64b View commit details
    Browse the repository at this point in the history

  47. Add note about func not being part of the base class 

    Co-authored-by: Erik Sundell <[email protected]>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f1f9d7e View commit details
    Browse the repository at this point in the history

  48. Add email to default check list of claims when specifics are not set

    @GeorgianaElena
    GeorgianaElena committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    cdd23e2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Workaround edge case when JupyterHub calls check_allowed during startup

    @consideRatio
    consideRatio committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    efa4e8a View commit details
    Browse the repository at this point in the history

  2. docs: update changelog preliniary

    @consideRatio
    consideRatio committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    66b35f8 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e70dd31 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. refactor: pure update of comments/docstrings/help and whitespace 

    The idea is to offload future commits by making these comment changes
separately.
    @consideRatio
    consideRatio committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    26d4c75 View commit details
    Browse the repository at this point in the history

  2. refactor, openshift: plain refactor for readability

    @consideRatio
    consideRatio committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8556e27 View commit details
    Browse the repository at this point in the history

  3. refactor, github: plain refactor for readability

    @consideRatio
    consideRatio committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    3c62101 View commit details
    Browse the repository at this point in the history

  4. refactor, google: rename _google_groups_for_user to _fetch_user_groups

    @consideRatio
    consideRatio committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    fd06b47 View commit details
    Browse the repository at this point in the history

  5. google, breaking fix: revoke admin status, groups are now sets in aut… 

    …h state
    @consideRatio
    consideRatio committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8acf905 View commit details
    Browse the repository at this point in the history

  6. globus, maint: persist globus groups in auth state, and misc refactor

    @consideRatio
    consideRatio committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8b138c7 View commit details
    Browse the repository at this point in the history