Make tests more robust #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't require connection to the internet for api tests to run (I was just on a plane!). Instead, we use the helper classes used in test_gitpuller for making arbitrary temporary git repos in test_api as well - Don't specify hardcoded names when creating our test git repos - instead, create truly temporary directories. - Stop swallowing exceptions that might occur when trying to fetch list of tags / branches in a remote. Without this commit, we were swallowing the output of the git command itself
yuvipanda
requested review from
consideRatio,
minrk,
manics and
betatim
and removed request for
consideRatio
|
This makes sense! It's great that you consider the helpfulness of error messages, it sure matters when it matters :) Linkback to other issues regarding error messages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I was just on a plane!). Instead, we use the helper classes
used in test_gitpuller for making arbitrary temporary git repos
in test_api as well
instead, create truly temporary directories.
list of tags / branches in a remote. Without this commit, we
were swallowing the output of the git command itself