Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve selection logic #542

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Improve selection logic #542

merged 2 commits into from
Oct 25, 2024

Conversation

martinRenou
Copy link
Member

Fix #487

This was tricky to get right with the flags, but that seems to work nicely!

Screencast.from.2024-10-25.17-17-46.mp4

@martinRenou martinRenou added the enhancement New Feature or improvement label Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Preview PR at appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Integration tests repot: appsharing.space

@SylvainCorlay
Copy link
Member

Awesome.

@SylvainCorlay SylvainCorlay merged commit 3961078 into jupytercad:main Oct 25, 2024
10 checks passed
@martinRenou martinRenou deleted the improve_selection_logic branch October 25, 2024 15:37
@arjxn-py arjxn-py mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New Feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On changing the selection when rotating/panning with the mouse
2 participants
@martinRenou @SylvainCorlay